Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bionic end-of-support RFC. #289

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Add Bionic end-of-support RFC. #289

merged 2 commits into from
Jun 7, 2023

Conversation

robdimsdale
Copy link
Member

@robdimsdale robdimsdale requested a review from a team as a code owner May 2, 2023 21:15
@robdimsdale robdimsdale requested review from a team, ryanmoran, paketo-bot-reviewer, ForestEckhardt and arjun024 and removed request for a team May 2, 2023 21:15
dmikusa
dmikusa reviewed May 3, 2023
View reviewed changes
text/0000-bionic-eos.md Outdated Show resolved Hide resolved
ForestEckhardt
ForestEckhardt previously approved these changes May 3, 2023
View reviewed changes
@ForestEckhardt ForestEckhardt dismissed their stale review May 3, 2023 14:17

Was on the wrong PR

@sophiewigmore
Copy link
Member

sophiewigmore commented May 4, 2023 •
edited
Loading

This all looks reasonable to me. I'm in agreement with Dan's comments above, but aside from that I approve of the content here. I'm holding off on an official approval for a bit longer while we wait for anyone in the community to voice questions/concerns.

@ForestEckhardt
Copy link
Contributor

@paketo-buildpacks/stacks-maintainers, @paketo-buildpacks/nodejs-maintainers, @paketo-buildpacks/ruby-maintainers, and @paketo-buildpacks/python-maintainers the EOS date is rapidly approaching. I think it would be smart for us to have this closed before that date so that work can start as soon as possible. Your feedback and review would be greatly appreciated!

@sophiewigmore
Copy link
Member

I have directly reached out to @paketo-buildpacks/nodejs-maintainers and @paketo-buildpacks/python-maintainers in Slack for their review

@sophiewigmore
Copy link
Member

@ForestEckhardt I think you now have all of the approvals you need from each team.

@ForestEckhardt ForestEckhardt merged commit 61aff87 into main Jun 7, 2023
@ForestEckhardt ForestEckhardt deleted the bionic-eos branch June 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TisVictress TisVictress TisVictress approved these changes

@joshuatcasey joshuatcasey joshuatcasey approved these changes

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@brayanhenao brayanhenao brayanhenao approved these changes

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@dmikusa dmikusa dmikusa approved these changes

@arjun024 arjun024 arjun024 approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran was automatically assigned from paketo-buildpacks/go-maintainers

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer was automatically assigned from paketo-buildpacks/go-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@robdimsdale @sophiewigmore @ForestEckhardt @arjun024 @dmikusa @brayanhenao @joshuatcasey @TisVictress