-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds reproducibility tests #818
Conversation
Passenger
|
Puma
|
Rackup
|
Rails
NOTE: container-diff must have some form of caching and it was giving me bad readings for images with the same name. |
Rake
|
Thin
|
Unicorn
|
I think that the deviation in runs for most of these happens somewhere in these lines of code https://github.com/ruby/ruby/blob/00f411c58ac6105f135ff4501ea5bd1d691fcc32/lib/mkmf.rb#L2000-L2014 but I am unclear on how it is happening. |
I have not been able to reproduce the the behavior where a seemingly random string is selected in the repl on the final build container. My next idea is to modify the |
96715c3
to
e61ed71
Compare
@ryanmoran I'd love to get these tests merged in to main before I cut a release of the ruby language family. Does anything else need to change here? |
Resolves #811
Checklist