Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name mismatch warnings #11

Merged

Conversation

vatanaksoytezer
Copy link

We are happily using backward_ros on MoveIt. Since the transition of Rolling to Jammy (thus to default cmake to be updated to 3.22), we are getting a flood of warnings related to FindPackageHandleStandardArgs every time we find package to backward_ros. This should hopefully fix it. We would be more than delighted for a new release of backward_ros on Rolling, so we don't have this flood.

Hope this makes sense. The fix was inspired from the same problem in catkin, here.

You can find a sample warning below:

CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (libbfd)
  does not match the name of the calling package (backward_ros).  This can
  lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /opt/ros/rolling/share/backward_ros/cmake/BackwardConfig.cmake:66 (find_package_handle_standard_args)
  /opt/ros/rolling/share/backward_ros/cmake/backward_rosConfig.cmake:41 (include)
  /root/ws_moveit2/install/moveit_common/share/moveit_common/cmake/moveit_package.cmake:36 (find_package)
  CMakeLists.txt:6 (moveit_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

@vatanaksoytezer
Copy link
Author

Friendly ping to @v-lopez, to see if this makes sense.

@v-lopez
Copy link
Contributor

v-lopez commented Mar 8, 2022

LGTM, but I am no longer working at PAL Robotics, pinging @jordan-palacios.

@vatanaksoytezer
Copy link
Author

vatanaksoytezer commented Mar 31, 2022

Another friendly ping to @jordan-palacios, to see if we can merge this and get a rolling release so we (and any package using this on rolling) is free of warnings.

@jordan-palacios jordan-palacios self-assigned this Mar 31, 2022
@jordan-palacios
Copy link
Contributor

Thanks for the collaboration. And sorry for the delay.

We'll try to release this ASAP.

@jordan-palacios jordan-palacios merged commit 977b904 into pal-robotics:foxy-devel Mar 31, 2022
@vatanaksoytezer
Copy link
Author

Thanks a lot Jordan, we appreciate all the help!

@saikishor
Copy link
Member

Hello @vatanaksoytezer,

We have requested for the release in the rolling distro. FYI: ros/rosdistro#32613

Best Regards,
PAL Robotics Team.

@vatanaksoytezer
Copy link
Author

@saikishor we appreciate the effort and the fast action, thank you very much!

@saikishor
Copy link
Member

Hello @vatanaksoytezer,

The package is already merged to rosdistro upstream : ros/rosdistro#32647

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants