Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[DNM - RC ONLY][ASTS] Changes to background task #7424

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mdaudali
Copy link
Contributor

@mdaudali mdaudali commented Nov 5, 2024

The algorithm for determining the point up to which we should update the min swept Ts relies on records being present when a bucket is opened, and progress persisting after a bucket is complete. The former is not true (records are created on close) and the latter doesn't work (we delete progress after a bucket is complete, but even if we didn't, the task cleans up progress, and would therefore stop the task from searching future buckets if it failed part way).

This is not being merged as is, as we should verify this is the direction we want to go in.

@changelog-app
Copy link

changelog-app bot commented Nov 5, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

[DNM - RC ONLY][ASTS] Changes to background task

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@ergo14 ergo14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for RC

@mdaudali mdaudali force-pushed the mdaudali/11-05-_dnm_-_rc_only_asts_changes_to_background_task branch from 9d992be to 008f0c6 Compare November 6, 2024 16:29
@mdaudali mdaudali changed the base branch from develop to mdaudali/11-05-_asts_fix_ensure_forward_progress_even_if_a_single_window_does_not_have_enough_timestamps November 6, 2024 16:29
@mdaudali mdaudali changed the base branch from mdaudali/11-05-_asts_fix_ensure_forward_progress_even_if_a_single_window_does_not_have_enough_timestamps to develop November 6, 2024 16:31
@changelog-app
Copy link

changelog-app bot commented Nov 6, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

[DNM - RC ONLY][ASTS] Changes to background task

Check the box to generate changelog(s)

  • Generate changelog entry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants