This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
[DNM - RC ONLY][ASTS] Changes to background task #7424
Open
mdaudali
wants to merge
3
commits into
develop
Choose a base branch
from
mdaudali/11-05-_dnm_-_rc_only_asts_changes_to_background_task
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DNM - RC ONLY][ASTS] Changes to background task #7424
mdaudali
wants to merge
3
commits into
develop
from
mdaudali/11-05-_dnm_-_rc_only_asts_changes_to_background_task
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ergo14
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only for RC
mdaudali
force-pushed
the
mdaudali/11-05-_dnm_-_rc_only_asts_changes_to_background_task
branch
from
November 6, 2024 16:29
9d992be
to
008f0c6
Compare
mdaudali
changed the base branch from
develop
to
mdaudali/11-05-_asts_fix_ensure_forward_progress_even_if_a_single_window_does_not_have_enough_timestamps
November 6, 2024 16:29
mdaudali
changed the base branch from
mdaudali/11-05-_asts_fix_ensure_forward_progress_even_if_a_single_window_does_not_have_enough_timestamps
to
develop
November 6, 2024 16:31
Generate changelog in
|
[skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm for determining the point up to which we should update the min swept Ts relies on records being present when a bucket is opened, and progress persisting after a bucket is complete. The former is not true (records are created on close) and the latter doesn't work (we delete progress after a bucket is complete, but even if we didn't, the task cleans up progress, and would therefore stop the task from searching future buckets if it failed part way).
This is not being merged as is, as we should verify this is the direction we want to go in.