[core] fix(PanelStack2): Prevent extra render due to updated previo…

…us panel (#6713)
palantir · Apr 19, 2024 · 4f034db · 4f034db · svc-palantir-github · Apr 19, 2024
1 parent d30a11f
commit 4f034db
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/core/src/components/panel-stack2/panelView2.tsx b/packages/core/src/components/panel-stack2/panelView2.tsx
@@ -60,12 +60,13 @@ export const PanelView2: PanelView2Component = <T extends Panel<object>>({
     previousPanel,
     showHeader,
 }: PanelView2Props<T>) => {
+    const hasPreviousPanel = previousPanel !== undefined;
     const handleClose = React.useCallback(() => {
         // only remove this panel if it is not the only one.
-        if (previousPanel !== undefined) {
+        if (hasPreviousPanel) {
             onClose(panel);
         }
-    }, [onClose, panel, previousPanel]);
+    }, [onClose, panel, hasPreviousPanel]);
 
     const maybeBackButton =
         previousPanel === undefined ? null : (