[core] chore: minor code style fixes for #6312 (#6335)

palantir · Aug 28, 2023 · 6ade0a8 · 6ade0a8 · adidahiya · Aug 28, 2023
1 parent 31988f9
commit 6ade0a8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/packages/core/src/components/forms/asyncControllableTextArea.tsx b/packages/core/src/components/forms/asyncControllableTextArea.tsx
@@ -4,15 +4,16 @@
 
 import * as React from "react";
 
-import { useAsyncControllableValue } from "./useAsyncControllableValue";
+import { DISPLAYNAME_PREFIX } from "../../common";
+import { useAsyncControllableValue } from "../../hooks/useAsyncControllableValue";
 
-export type IAsyncControllableTextAreaProps = React.TextareaHTMLAttributes<HTMLTextAreaElement>;
+export type AsyncControllableTextAreaProps = React.TextareaHTMLAttributes<HTMLTextAreaElement>;
 
 /**
  * A wrapper around the low-level <textarea> component which works around a React bug
  * the same way <AsyncControllableInput> does.
  */
-export const AsyncControllableTextArea = React.forwardRef<HTMLTextAreaElement, IAsyncControllableTextAreaProps>(
+export const AsyncControllableTextArea = React.forwardRef<HTMLTextAreaElement, AsyncControllableTextAreaProps>(
     function _AsyncControllableTextArea(props, ref) {
         const {
             value: parentValue,
@@ -41,3 +42,4 @@ export const AsyncControllableTextArea = React.forwardRef<HTMLTextAreaElement, I
         );
     },
 );
+AsyncControllableTextArea.displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableTextArea`;
diff --git a/packages/core/src/hooks/index.ts b/packages/core/src/hooks/index.ts
@@ -16,3 +16,4 @@
 
 export { HotkeyConfig } from "./hotkeys/hotkeyConfig";
 export { useHotkeys, UseHotkeysOptions, UseHotkeysReturnValue } from "./hotkeys/useHotkeys";
+export { useAsyncControllableValue } from "./useAsyncControllableValue";
diff --git a/...onents/forms/useAsyncControllableValue.ts → ...re/src/hooks/useAsyncControllableValue.ts b/...onents/forms/useAsyncControllableValue.ts → ...re/src/hooks/useAsyncControllableValue.ts
@@ -4,7 +4,7 @@
 
 import * as React from "react";
 
-interface IUseAsyncControllableValueProps<E extends HTMLInputElement | HTMLTextAreaElement> {
+interface UseAsyncControllableValueProps<E extends HTMLInputElement | HTMLTextAreaElement> {
     value?: React.InputHTMLAttributes<E>["value"];
     onChange?: React.ChangeEventHandler<E>;
     onCompositionStart?: React.CompositionEventHandler<E>;
@@ -25,7 +25,7 @@ export const ASYNC_CONTROLLABLE_VALUE_COMPOSITION_END_DELAY = 10;
  * returned by the input's `onChange` callback.
  */
 export function useAsyncControllableValue<E extends HTMLInputElement | HTMLTextAreaElement>(
-    props: IUseAsyncControllableValueProps<E>,
+    props: UseAsyncControllableValueProps<E>,
 ) {
     const { onCompositionStart, onCompositionEnd, value: propValue, onChange } = props;
 

diff --git a/packages/core/test/forms/asyncControllableInputTests.tsx b/packages/core/test/forms/asyncControllableInputTests.tsx
@@ -24,7 +24,7 @@ import { spy } from "sinon";
 // this component is not part of the public API, but we want to test its implementation in isolation
 import { AsyncControllableInput } from "../../src/components/forms/asyncControllableInput";
 import { AsyncControllableTextArea } from "../../src/components/forms/asyncControllableTextArea";
-import { ASYNC_CONTROLLABLE_VALUE_COMPOSITION_END_DELAY } from "../../src/components/forms/useAsyncControllableValue";
+import { ASYNC_CONTROLLABLE_VALUE_COMPOSITION_END_DELAY } from "../../src/hooks/useAsyncControllableValue";
 import { sleep } from "../utils";
 
 /*
Original file line number	Diff line number	Diff line change
Expand Up		@@ -16,3 +16,4 @@

		export { HotkeyConfig } from "./hotkeys/hotkeyConfig";
		export { useHotkeys, UseHotkeysOptions, UseHotkeysReturnValue } from "./hotkeys/useHotkeys";
		export { useAsyncControllableValue } from "./useAsyncControllableValue";