[core] fix: do not colour FormGroup sub label based on intent (#6811)

Co-authored-by: svc-changelog <svc-changelog@palantir.com>
palantir · May 20, 2024 · 772e44c · 772e44c · svc-palantir-github · May 20, 2024
1 parent 79010df
commit 772e44c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/core/changelog/@unreleased/pr-6811.v2.yml b/packages/core/changelog/@unreleased/pr-6811.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Do not colour FormGroup sub label based on intent
+  links:
+  - https://github.com/palantir/blueprint/pull/6811
diff --git a/packages/core/src/components/forms/_form-group.scss b/packages/core/src/components/forms/_form-group.scss
@@ -62,7 +62,6 @@ Styleguide form-group
   /* stylelint-disable-next-line order/declaration-block-order */
   @each $intent, $color in $pt-intent-text-colors {
     &.#{$ns}-intent-#{$intent} {
-      .#{$ns}-form-group-sub-label,
       .#{$ns}-form-helper-text {
         color: $color;
       }
@@ -102,7 +101,6 @@ Styleguide form-group
   .#{$ns}-dark & {
     @each $intent, $color in $pt-dark-intent-text-colors {
       &.#{$ns}-intent-#{$intent} {
-        .#{$ns}-form-group-sub-label,
         .#{$ns}-form-helper-text {
           color: $color;
         }

diff --git a/packages/core/src/components/forms/formGroup.tsx b/packages/core/src/components/forms/formGroup.tsx
@@ -76,8 +76,7 @@ export interface FormGroupProps extends IntentProps, Props {
 
     /**
      * Optional text for `label`. The given content will be wrapped in
-     * `Classes.FORM_GROUP_SUB_LABEL` and displayed beneath `label`. The text color
-     * is determined by the `intent`.
+     * `Classes.FORM_GROUP_SUB_LABEL` and displayed beneath `label`.
      */
     subLabel?: React.ReactNode;
 }