[v4] [core] fix(Textarea): match text input border style (#5006)

palantir · Nov 3, 2021 · d20a08c · d20a08c · blueprint-bot · Nov 3, 2021
1 parent 7244616
commit d20a08c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 29 deletions.
diff --git a/packages/core/src/blueprint.scss b/packages/core/src/blueprint.scss
@@ -286,38 +286,36 @@ table.#{$ns}-html-table {
 }
 
 // Contrast for inputs
-.#{$ns}-input-group {
-  .#{$ns}-input {
-    // Use intent-styled box-shadows for default intent
-    box-shadow: input-transition-shadow($input-shadow-color-focus),
-        inset border-shadow(1, $gray2),
-        $pt-input-box-shadow;
+.#{$ns}-input {
+  // Use intent-styled box-shadows for default intent
+  box-shadow: input-transition-shadow($input-shadow-color-focus),
+      inset border-shadow(1, $gray2),
+      $pt-input-box-shadow;
 
-    &:focus {
-      box-shadow: input-transition-shadow($input-shadow-color-focus, true), $input-box-shadow-focus;
-    }
+  &:focus {
+    box-shadow: input-transition-shadow($input-shadow-color-focus, true), $input-box-shadow-focus;
+  }
 
-    .#{$ns}-dark & {
-      box-shadow: dark-input-transition-shadow($dark-input-shadow-color-focus),
-        inset border-shadow(1, $gray3),
-        $pt-dark-input-box-shadow;
+  .#{$ns}-dark & {
+    box-shadow: dark-input-transition-shadow($dark-input-shadow-color-focus),
+      inset border-shadow(1, $gray3),
+      $pt-dark-input-box-shadow;
 
-      &:focus {
-        box-shadow: dark-input-transition-shadow($dark-input-shadow-color-focus, true),
-                      $pt-dark-input-box-shadow;
-      }
+    &:focus {
+      box-shadow: dark-input-transition-shadow($dark-input-shadow-color-focus, true),
+                    $pt-dark-input-box-shadow;
     }
+  }
 
-    &:disabled {
-      box-shadow: none;
-    }
+  &:disabled {
+    box-shadow: none;
   }
+}
 
-  @each $intent, $color in $dark-input-intent-box-shadow-colors {
-    &.#{$ns}-intent-#{$intent} {
-      .#{$ns}-input {
-        @include pt-dark-input-intent($color);
-      }
+@each $intent, $color in $dark-input-intent-box-shadow-colors {
+  &.#{$ns}-intent-#{$intent} {
+    .#{$ns}-input {
+      @include pt-dark-input-intent($color);
     }
   }
 }

diff --git a/packages/core/src/components/forms/_input.scss b/packages/core/src/components/forms/_input.scss
@@ -108,8 +108,4 @@ textarea.#{$ns}-input {
   &.#{$ns}-small {
     padding: $input-small-padding;
   }
-
-  .#{$ns}-dark & {
-    @include pt-dark-input();
-  }
 }