[core] fix(NumericInput): increment/decrement w/ small step size (#6382)

palantir · Sep 22, 2023 · e15084f · e15084f · adidahiya · Sep 22, 2023
1 parent 519e9ae
commit e15084f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/core/src/components/forms/numericInputUtils.ts b/packages/core/src/components/forms/numericInputUtils.ts
@@ -30,7 +30,8 @@ function getDecimalSeparator(locale: string) {
 }
 
 export function toLocaleString(num: number, locale: string = "en-US") {
-    return sanitizeNumericInput(num.toLocaleString(locale), locale);
+    // HACKHACK: roundingPriority is not supported yet in TypeScript https://github.com/microsoft/TypeScript/issues/43336
+    return sanitizeNumericInput(num.toLocaleString(locale, { roundingPriority: "morePrecision" } as any), locale);
 }
 
 export function clampValue(value: number, min?: number, max?: number) {

diff --git a/packages/core/test/controls/numericInputTests.tsx b/packages/core/test/controls/numericInputTests.tsx
@@ -1103,6 +1103,21 @@ describe("<NumericInput>", () => {
             expect(component.find("input").prop("value")).to.equal("1.001");
         });
 
+        it("handle big decimal numbers", () => {
+            const onValueChangeSpy = spy();
+            const component = mount(
+                <NumericInput
+                    onValueChange={onValueChangeSpy}
+                    value={0}
+                    stepSize={0.000000000000000001}
+                    minorStepSize={0.000000000000000001}
+                />,
+            );
+            const input = component.find("input");
+            input.simulate("keydown", { key: "ArrowUp" });
+            assert.isTrue(onValueChangeSpy.calledWith(0.000000000000000001));
+        });
+
         it("changes max precision appropriately when the min/max stepSize props change", () => {
             const onValueChangeSpy = spy();
             const component = mount(