[core] fix(IconProps): widen type of HTML attributes

palantir · Jul 17, 2023 · eb4eff6 · eb4eff6 · adidahiya · Jul 17, 2023
1 parent 214cc02
commit eb4eff6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/components/icon/icon.tsx b/packages/core/src/components/icon/icon.tsx
@@ -24,7 +24,7 @@ import { Classes, DISPLAYNAME_PREFIX, IntentProps, MaybeElement, Props, removeNo
 // re-export for convenience, since some users won't be importing from or have a direct dependency on the icons package
 export { IconName, IconSize };
 
-export type IconHTMLAttributes = Omit<React.HTMLAttributes<HTMLElement | SVGSVGElement>, "children" | "title">;
+export type IconHTMLAttributes = Omit<React.HTMLAttributes<HTMLOrSVGElement>, "children" | "title">;
 
 export interface IconProps extends IntentProps, Props, SVGIconProps, IconHTMLAttributes {
     /**

diff --git a/packages/icons/src/svgIconProps.ts b/packages/icons/src/svgIconProps.ts
@@ -21,7 +21,7 @@ import * as React from "react";
  */
 export interface SVGIconProps
     extends React.RefAttributes<any>,
-        Omit<React.DOMAttributes<HTMLElement | SVGSVGElement>, "children" | "dangerouslySetInnerHTML"> {
+        Omit<React.DOMAttributes<HTMLOrSVGElement>, "children" | "dangerouslySetInnerHTML"> {
     /** A space-delimited list of class names to pass along to the SVG element. */
     className?: string;