Skip to content

Commit

Permalink
Add isComposing check to EditableText toggleEdit (#7021)
Browse files Browse the repository at this point in the history 
Co-authored-by: Natsu Ozawa <nozawa@palantir.com>
  • Loading branch information
@natsuozawa
natsuozawa and Natsu Ozawa authored Oct 23, 2024
1 parent d78625c commit ee26faf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/core/src/components/editable-text/editableText.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ export class EditableText extends AbstractPureComponent<EditableTextProps, Edita
}

const hasModifierKey = altKey || ctrlKey || metaKey || shiftKey;
if (event.key === "Enter") {
if (event.key === "Enter" && !event.nativeEvent.isComposing) {
// prevent browsers (Edge?) from full screening with alt + enter
// shift + enter adds a newline by default
if (altKey || shiftKey) {
Expand Down

1 comment on commit ee26faf

@svc-palantir-github
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add isComposing check to EditableText toggleEdit (#7021)

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Please sign in to comment.