Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toasts position is broken #2232

Closed
Grmiade opened this issue Mar 14, 2018 · 1 comment
Closed

Toasts position is broken #2232

Grmiade opened this issue Mar 14, 2018 · 1 comment

Comments

@Grmiade
Copy link

Grmiade commented Mar 14, 2018

Bug report

  • Package version(s): 2.0-rc3
  • Browser and OS versions: Tested on Chrome

Steps to reproduce

  1. In docs, select a position
  2. And click on buttons to show toasts

Actual behavior

The chosen position seems not be correctly applied. And break the toast style 😱

screen shot 2018-03-14 at 11 18 20

screen shot 2018-03-14 at 11 18 27

screen shot 2018-03-14 at 11 18 36

Expected behavior

The old behavior :) With correct position.

@Grmiade Grmiade changed the title Toasts position is broked Toasts position is broken Mar 14, 2018
@reiv
Copy link
Contributor

reiv commented Mar 14, 2018

This seems to be a regression introduced in 2d7f756.

Specifically, a <div> that previously existed as a child of .pt-toast-container and parent of .pt-toast is no longer rendered as a result of that commit, and its styles are now applied directly to the .pt-toast <div>:

// TransitionGroup
> div {
display: flex;
flex-direction: column;
align-items: center;
// prevent container from scrolling as new toasts enter (from bottom)
overflow: hidden;
// ensure there's enough space for full box-shadow
padding: 0 $toast-margin $toast-margin;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants