Support sass 4's @extend SELECTOR, SELECTOR

[DTrejo]

Really enjoying blueprint in our project.

Goal: We'd like to use parcel to import and customize blueprint's CSS. This piece of syntax causes sass 4 to break when it tries to import it. Would it be possible to make it sass 4 compatible? Thanks!

The build error disappeared when I did this:

-@extend .#{$ns}-menu-item:hover;
+@extend .#{$ns}-menu-item, :hover;

---

blueprint/packages/core/src/components/menu/_submenu.scss

Line 19 in efb0b5b

@extend .#{$ns}-menu-item:hover;

---

Full error message

compound selectors may no longer be extended.
Consider `@extend .bp3-menu-item, :hover` instead.
See http://bit.ly/ExtendCompound for details.

╷
19 │ @extend .#{$ns}-menu-item:hover;
│ ^^^^^^^^^^^^^^^^^^^^^^^
╵
node_modules/@blueprintjs/core/src/components/menu/_submenu.scss 19:15 root stylesheet
Error: compound selectors may no longer be extended.
Consider `@extend .bp3-menu-item, :hover` instead.
See http://bit.ly/ExtendCompound for details.

   ╷
19 │       @extend .#{$ns}-menu-item:hover;
   │               ^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  node_modules/@blueprintjs/core/src/components/menu/_submenu.scss 19:15  root stylesheet

Note: I also used this workaround to avoid needing to use svg-icon #2976 (comment)

Note: I also use this .sassrc to support ~ tilde in sass import paths:

{
  "includePaths": [
    "node_modules"
  ]
}

[adidahiya]

looks like a duplicate of #4032. we don't import Blueprint Sass files and customize them in our internal repos, so we haven't hit this bug. I would be open to a bugfix PR as long as it's not a breaking change

[DTrejo]

Oops, sorry! Feel free to close / consolidate :) Thanks for your hard work on blueprint!

…

On Wed, Apr 22, 2020 at 8:43 PM Adi Dahiya ***@***.***> wrote: looks like a duplicate of #4032 <#4032>. we don't import Blueprint Sass files and customize them in our internal repos, so we haven't hit this bug. I would be open to a bugfix PR as long as it's not a breaking change — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4088 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANWN3TE3GDEE2V4ORPVF3RN62PPANCNFSM4MOV4NSQ> .