Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill prop doesn't work on MultiSelect 2 (when coming from MultiSelect) #5353

Closed
bvandercar-vt opened this issue Jun 3, 2022 · 2 comments · Fixed by #5354
Closed

Fill prop doesn't work on MultiSelect 2 (when coming from MultiSelect) #5353

bvandercar-vt opened this issue Jun 3, 2022 · 2 comments · Fixed by #5354
Assignees
@adidahiya
Labels
P2 Package: select Type: bug

Comments

@bvandercar-vt
Copy link
Contributor

bvandercar-vt commented Jun 3, 2022 •
edited
Loading

Environment

  • Package version(s): 4.4.0
  • Operating System: Windows
  • Browser name and version: Chrome

Steps to reproduce

  1. Can see this doesn't work by visiting MultiSelect2 example page https://blueprintjs.com/docs/#select/multi-select2 . "Fill container width" does not work

Actual behavior

MultiSelect2 fill prop doesn't work.

Expected behavior

MultiSelect2 fill prop to work the same as the original MultiSelect's did
@adidahiya adidahiya self-assigned this Jun 3, 2022
@adidahiya adidahiya mentioned this issue Jun 3, 2022
Merged
2 tasks
@adidahiya
Copy link
Contributor

Looks like Select2 and Suggest2 also have this problem:

image

image

@adidahiya
Copy link
Contributor

Fixed in #5354, and I also improved the examples for each of these so we can test the props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
P2 Package: select Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[select] fix: use renderTarget API to fix fill prop palantir/blueprint
2 participants
@adidahiya @bvandercar-vt