-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[select] fix: use renderTarget API to fix fill prop #5354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert margin changePreviews: documentation | landing | table | demo |
adidahiya
changed the title
[select] fix(MultiSelect2): use renderTarget API to fix fill prop
[select] fix: use renderTarget API to fix fill prop
Jun 3, 2022
Fix typedefPreviews: documentation | landing | table | demo |
fix testPreviews: documentation | landing | table | demo |
Fix this.state.isOpen referencesPreviews: documentation | landing | table | demo |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5353
Checklist
Changes proposed in this pull request:
Select2, Suggest2, MultiSelect2:
fill
prop, which did not work and was a regression from the V1 componentsrenderTarget
API, and has the added benefit of collapsing the DOM rendered by the componentsdisabled
,fill
,matchTargetWidth
propsSelect2, MultiSelect2:
matchTargetWidth
styling so that the width of the popup menu is no longer constrainedMultiSelect2:
disabled?: boolean
propReviewers should focus on:
No regressions, passing test suite
Screenshot