Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateRangeInput2]: footerElement prop does not render #5537

Closed
fnziman opened this issue Sep 12, 2022 · 2 comments · Fixed by #5539
Closed

[DateRangeInput2]: footerElement prop does not render #5537

fnziman opened this issue Sep 12, 2022 · 2 comments · Fixed by #5539

Comments

@fnziman
Copy link
Contributor

fnziman commented Sep 12, 2022

Environment

  • Package version(s): "@blueprintjs/core": "^4.7.0",
    "@blueprintjs/datetime": "^4.3.4",
    "@blueprintjs/datetime2": "^0.5.0",
    "@blueprintjs/popover2": "^1.5.0",
    "@blueprintjs/select": "^4.5.2",
    "@blueprintjs/table": "^4.5.0",
    "@blueprintjs/timezone": "^4.4.4",
  • Operating System: MacOs Monterey 12.1
  • Browser name and version: Chrome Version 104.0.5112.101

Code Sandbox

Example

Steps to reproduce

  1. add footerElement prop to DateRangeInput2
  2. ensure that it does not render

Actual behavior

No footer component rendered

Expected behavior

Render footer component

Possible solution

It seems that the prop is not used at all by DateRangeInput or by DateRangeInput2. Both DateInput and DateRangeInput, do render it. I think it just needs to be added

@fnziman
Copy link
Contributor Author

fnziman commented Sep 13, 2022

Included a fix here: #5538

@adidahiya
Copy link
Contributor

Thanks for the bug report! This looks like an oversight. I'll review your PR to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants