Fz/date range input footer element #5538
Conversation
|
Thanks for your interest in palantir/blueprint, @fnziman! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| {this.renderCalendars(isShowingOneMonth)} | ||
| {this.maybeRenderTimePickers()} | ||
| <div className={DateClasses.DATEPICKER_CONTENT}> | ||
| <div> |
There was a problem hiding this comment.
This doesn't seem like the ideal DOM structure... it probably makes more sense for the calendar(s) and time picker(s) to live adjacent to the footer element. I would like to see more options added to the docs example so we can test out this new layout. I'll try to push my ideas as a commit on your branch.
There was a problem hiding this comment.
I made an update that I think is more what you are looking for..
| <div> | ||
| {this.renderCalendars(isShowingOneMonth)} | ||
| {this.maybeRenderTimePickers()} | ||
| <div className={DateClasses.DATEPICKER_CONTENT}> |
There was a problem hiding this comment.
also this CSS class was named for and designed for "datepicker", not "date range picker", so we'll need to make a new class to keep the naming semantics clear
|
Rendering the footer element exposed a few layout issues with the multiple calendars and time pickers rendered by DateRangePicker. I also discovered an unrelated bug where it renders two time pickers even when |
|
Thanks for the attempted PR -- I'm going to close this in favor of my new one, but you'll still get credited as a collaborator on the commit when that PR merges :) |
Fixes #5537
Checklist
Changes proposed in this pull request:
Adds the footerElement to the DateRangePicker
Reviewers should focus on:
Seeing that the footer now works
Screenshot