Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest2 menu items no longer scrollable #5664

Closed
williamphan opened this issue Oct 10, 2022 · 2 comments · Fixed by #5667
Closed

Suggest2 menu items no longer scrollable #5664

williamphan opened this issue Oct 10, 2022 · 2 comments · Fixed by #5667

Comments

@williamphan
Copy link

Environment

  • Package version(s): v4
  • Operating System: macOS
  • Browser name and version: Chrome, Safari

Code Sandbox

It's not working in the documentation either. https://blueprintjs.com/docs/#select/suggest2

image

Actual behavior

The whole list (suggest result) is visible and no longer scrollable. It is clipped if the results are longer than the page height.

Expected behavior

The list should be cut off (max-height) and scrollable if the result doesn't fit.

Possible solution

Add max-height and overflow. V3 works fine.

@adidahiya
Copy link
Contributor

adidahiya commented Oct 10, 2022

@williamphan thanks for the bug report. It's helpful if you can be more specific about the version number than simply "v4" (there are many versions under v4.x)

It looks like this bug has existed for Suggest2 for a while, at least since @blueprintjs/select v4.6.x -- I'll try to fix it ASAP.

@adidahiya
Copy link
Contributor

Bug was introduced in #5369, will be fixed by #5667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants