Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix: various fixes, class name deprecation #5369

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

adidahiya
Copy link
Contributor

  • deprecation: Classes.SELECT exported from this package is not rendered by any component, so it is not useful as public API
  • fix(Suggest2): popover element uses a new, more specific class .bp4-suggest-popover instead of re-using the one from Select2 .bp4-select-popover
  • fix(Select2, Suggest2, MultiSelect2): scoped down type of popoverProps to remove properties which are not meaningful to override
  • fix(Select2, Suggest2, MultiSelect2): no longer allow both placement and position to be set on the Popover2, to avoid a prop validation warning
  • fix(MultiSelect2): ⚠️ [BREAKING] selectedItems prop is now required, not optional

@adidahiya adidahiya changed the title [select] fix: various fixes [select] fix: various fixes, one class name deprecation Jun 13, 2022
@adidahiya adidahiya changed the title [select] fix: various fixes, one class name deprecation [select] fix: various fixes, class name deprecation Jun 13, 2022
@blueprint-bot
Copy link

remove unused import, fix code style

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

fix tests

Previews: documentation | landing | table | demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants