Regression in box-shadow Sass variable syntax

[adidahiya]

Environment

• Package version(s): @blueprintjs/core v4.17.0

Actual behavior

box-shadow variables have extra commas which make them unusable in box-shadow: $pt-elevation-box-shadow Sass usage

$pt-elevation-shadow-0: 0, 0, 0, 1px, rgba(17, 20, 24, 0.15) !default;

Expected behavior

they were fine in v4.16.x variables.scss:

$pt-elevation-shadow-0: 0 0 0 1px rgba(17, 20, 24, 0.15) !default;

Possible solution

Caused by #5904, need to look into how we generate CSS variables...

[adidahiya]

It seems like the quotes on strings got dropped too.

Before:

$icons16-family: "blueprint-icons-16" !default;
$icons20-family: "blueprint-icons-20" !default;

$pt-icon-size-standard: 16px !default;
$pt-icon-size-large: 20px !default;

$pt-font-family: -apple-system, "BlinkMacSystemFont", "Segoe UI", "Roboto",
  "Oxygen", "Ubuntu", "Cantarell", "Open Sans", "Helvetica Neue",
  "blueprint-icons-16", sans-serif !default;

After:

$icons16-family: blueprint-icons-16 !default;
$icons20-family: blueprint-icons-20 !default;

$pt-icon-size-standard: 16px !default;
$pt-icon-size-large: 20px !default;

$pt-font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Oxygen,
  Ubuntu, Cantarell, Open Sans, Helvetica Neue, blueprint-icons-16, sans-serif !default;

[adidahiya]

Note that these variables are only broken for consumers of the Sass variables, and not internally in Blueprint styles: