[core] fix CSS syntax in box-shadow variables #5989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5987
Checklist
Changes proposed in this pull request:
generate-css-variables
implementation into testable functionsgenerate-css-variables
implementation to use postcss-simple-vars instead of get-sass-varsrgba($black, 0.1)
where the first argument is a hex color value -- we now replace those variables with literal r, g, and b values likergba(17, 20, 24, 0.1)
.Reviewers should focus on:
Regression tests cover the functionality that we care about.
I compared the Sass variables output against this last known working version: https://unpkg.com/browse/@blueprintjs/core@4.16.3/lib/scss/variables.scss
Screenshot
N/A