Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling portalStopPropagationEvents for a dialog cases button popovers to not work #6428

Closed
PhoebeSzmucer opened this issue Oct 4, 2023 · 1 comment · Fixed by #6632
Closed

Enabling portalStopPropagationEvents for a dialog cases button popovers to not work #6428

PhoebeSzmucer opened this issue Oct 4, 2023 · 1 comment · Fixed by #6632
Labels
help wanted P2 Package: core Type: bug

Comments

@PhoebeSzmucer
Copy link
Contributor

Environment

  • Package version(s): 4.19.0+ (since this PR)

Code Sandbox

https://codesandbox.io/p/sandbox/wizardly-leftpad-yfhw8n?file=%2Fsrc%2FCoreExample.tsx%3A22%2C56

Steps to reproduce

Add portalStopPropagationEvents={["click"]} to a dialog (or a portal) that renders a popover inside of it.

Actual behavior

Popover doesn't open

Expected behavior

Popover should open
@adidahiya
Copy link
Contributor

I forked/updated your sandbox to use the latest popover2 package version and I can still repro the bug: https://codesandbox.io/p/sandbox/wizardly-leftpad-yfhw8n?file=%2Fsrc%2FCoreExample.tsx%3A22%2C56

@adidahiya adidahiya mentioned this issue Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted P2 Package: core Type: bug
Projects
Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] deprecate Portal stopPropagationEvents palantir/blueprint
2 participants
@adidahiya @PhoebeSzmucer