[core] deprecate Portal stopPropagationEvents #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] deprecate Overlay portalStopPropagationEventsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
gluxon
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks @adidahiya! Plan sounds good to me.
(I agree the original problem portalStopPropagationEvents was addressing is a real one. Unfortunate our workaround doesn't work on React 17+.)
revert whitespace changeBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
deprecate on Portal component tooBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #6580, fixes #6428
Changes proposed in this pull request:
Deprecate
portalStopPropagationEvents(added in #6093) since its implementation is not effective in React 17+ and stopping event propagation is discouraged anyway. We should come up with an alternative solution for the problem this was trying to solve.