-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal context class #1244
Merged
Merged
Portal context class #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your interest in palantir/blueprint, @jrafidi! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Let's add something like this to
|
Update docsPreview: documentation |
adidahiya
approved these changes
Jun 16, 2017
Merged
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Add a context property called
blueprintPortalClass
that all Blueprint Portals respect. This is very beneficial if you are displaying dialogs within a shared component/larger plugin and want to scope your styles. You could go through to every instance of Popover/Dialog/Tooltip and add the class yourself, but you're likely to forget to do it the next time you add something.Not sure how to update documentation on this one. Also open to suggestions on the context prop name.
Side note: writing the tests for this was confusing/tricky because the tests started with 3 Portals in wherever enzyme puts them. I would have expected to start with an empty space to test. Is there a chance something isn't cleaning up properly?