[Table] Add truncation controls to example page #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprint into cl/table-example-truncation
Merge branch 'cl/table-example-truncation' of github.com:palantir/blueprint into cl/table-example-truncationPreview: documentation | table |
Show disabled child elements in sidebar, use Classes everywherePreview: documentation | table |
cmslewis
force-pushed
the
cl/table-example-truncation
branch
from
fda14f1 to
424cde4
Compare
|
@llorca @tgreenwatts I updated the code and the GIF above. See how the new enable/disable toggling feels. EDIT: Well, wait till the latest build finishes. |
Show disabled child elements in sidebar, use Classes everywherePreview: documentation | table |
llorca
approved these changes
Jun 20, 2017
Merged
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
On the table playground page:
ALWAYS,NEVER,WHEN_TRUNCATED).Reviewers should focus on:
Behold how slow and laggy truncation makes the table feel. :)
I periodically see
Maximum call stack size exceedederrors in the console when I change the truncation popover mode. Not sure why. Help me figure it out if you see it?Screenshot