Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EditableText] Improve tests for onConfirm and onCancel behavior #1310

Merged
merged 4 commits into from
Jul 7, 2017
Merged

[EditableText] Improve tests for onConfirm and onCancel behavior #1310

merged 4 commits into from
Jul 7, 2017

Conversation

cmslewis
Copy link
Contributor

Verifies behavior that was reportedly buggy in #975

Checklist

  • Include tests

Changes proposed in this pull request:

  • Improved test for onConfirm behavior.
    • Verify that onCancel was not called.
    • Verify that new value was saved in input.
  • Improved test for onCancel behavior.
    • Verify that onConfirm was not called.
    • Verify that new value was saved in input.
  • Add test to verify that onConfirm was called when Enter pressed with unchanged value.

Reviewers should focus on:

Screenshot

@cmslewis cmslewis added this to the 1.22.0 milestone Jun 30, 2017
@cmslewis cmslewis requested review from llorca and giladgray June 30, 2017 23:17
@cmslewis cmslewis force-pushed the cl/editabletext-975 branch from af0d64f to 3f1269e Compare June 30, 2017 23:18
@cmslewis cmslewis mentioned this pull request Jun 30, 2017
Closed
@blueprint-bot
Copy link

Cleanups

Preview: documentation
Coverage: core | datetime

@llorca llorca modified the milestones: 1.22.0, 1.23.0 Jul 5, 2017
@adidahiya adidahiya merged commit 8c626c3 into master Jul 7, 2017
@adidahiya adidahiya deleted the cl/editabletext-975 branch July 7, 2017 21:37
@llorca llorca mentioned this pull request Jul 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@llorca llorca Awaiting requested review from llorca

@giladgray giladgray Awaiting requested review from giladgray

Assignees
No one assigned
Labels
Domain: testing
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmslewis @blueprint-bot @adidahiya @llorca