Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateRangePicker] Disable out-of-range shortcuts #1311

Merged
merged 4 commits into from
Jul 7, 2017
Merged

[DateRangePicker] Disable out-of-range shortcuts #1311

merged 4 commits into from
Jul 7, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Jul 1, 2017 •
edited
Loading

Fixes #608

Checklist

  • Include tests
  • Update documentation

Changes proposed in this pull request:

  • Fixed DateRangePicker now disables shortcuts that aren't fully contained in [minDate, maxDate], inclusive.
    • Add "Minimum date" and "Maximum date" dropdowns to the DateRangePicker example to verify.

@cmslewis cmslewis requested review from llorca and giladgray July 1, 2017 00:59
@blueprint-bot
Copy link

Add tests

Preview: documentation
Coverage: core | datetime

@adidahiya adidahiya merged commit a6442c5 into master Jul 7, 2017
@adidahiya adidahiya deleted the cl/daterangepicker-608 branch July 7, 2017 21:46
@llorca llorca mentioned this pull request Jul 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@llorca llorca Awaiting requested review from llorca

@giladgray giladgray Awaiting requested review from giladgray

Assignees
No one assigned
Labels
Package: datetime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmslewis @blueprint-bot @adidahiya