React 16 and Enzyme 3 migration #1885
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "version": "2.6.2", | ||
| "compilerOptions": { | ||
| "declaration": true, | ||
| "experimentalDecorators": true, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | ||
| * | ||
| * Licensed under the terms of the LICENSE file distributed with this project. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
| import { isNodeEnv } from "./utils"; | ||
|
|
||
| /** | ||
| * An abstract component that Blueprint components can extend | ||
| * in order to add some common functionality like runtime props validation. | ||
| */ | ||
| export abstract class AbstractPureComponent<P, S> extends React.PureComponent<P, S> { | ||
| /** Component displayName should be `public static`. This property exists to prevent incorrect usage. */ | ||
| protected displayName: never; | ||
|
|
||
| // Not bothering to remove entries when their timeouts finish because clearing invalid ID is a no-op | ||
| private timeoutIds: number[] = []; | ||
|
|
||
| constructor(props?: P, context?: any) { | ||
| super(props, context); | ||
| if (!isNodeEnv("production")) { | ||
| this.validateProps(this.props); | ||
| } | ||
| } | ||
|
|
||
| public componentWillReceiveProps(nextProps: P & { children?: React.ReactNode }) { | ||
| if (!isNodeEnv("production")) { | ||
| this.validateProps(nextProps); | ||
| } | ||
| } | ||
|
|
||
| public componentWillUnmount() { | ||
| this.clearTimeouts(); | ||
| } | ||
|
|
||
| /** | ||
| * Set a timeout and remember its ID. | ||
| * All stored timeouts will be cleared when component unmounts. | ||
| * @returns a "cancel" function that will clear timeout when invoked. | ||
| */ | ||
| public setTimeout(callback: () => void, timeout?: number) { | ||
| const handle = window.setTimeout(callback, timeout); | ||
| this.timeoutIds.push(handle); | ||
| return () => window.clearTimeout(handle); | ||
| } | ||
|
|
||
| /** | ||
| * Clear all known timeouts. | ||
| */ | ||
| public clearTimeouts = () => { | ||
| if (this.timeoutIds.length > 0) { | ||
| for (const timeoutId of this.timeoutIds) { | ||
| window.clearTimeout(timeoutId); | ||
| } | ||
| this.timeoutIds = []; | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Ensures that the props specified for a component are valid. | ||
| * Implementations should check that props are valid and usually throw an Error if they are not. | ||
| * Implementations should not duplicate checks that the type system already guarantees. | ||
| * | ||
| * This method should be used instead of React's | ||
| * [propTypes](https://facebook.github.io/react/docs/reusable-components.html#prop-validation) feature. | ||
| * In contrast to propTypes, these runtime checks are _always_ run, not just in development mode. | ||
| */ | ||
| protected validateProps(_: P & { children?: React.ReactNode }) { | ||
| // implement in subclass | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these actually deprecated if they're being replaced by labs components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to remember to remove this line when @cmslewis's Popover2 -> Popover change goes in.