-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16 and Enzyme 3 migration #1885
Merged
Merged
Changes from 6 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
817d141
Bump to react 16, regen lockfile
adidahiya 4478ac8
pure-render-decorator -> React.PureComponent
adidahiya c5a98e4
Migrate to react-transition-group
adidahiya 73d7a8e
Migrate to ReactDOM.createPortal
adidahiya 3df77f1
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya 49f8069
Fix Table component shouldComponentUpdate warnings
adidahiya c2074d5
Restore wrapper div for Portal component
adidahiya ab2c99b
Upgrade enzyme, install enzyme-adapter-react-16
adidahiya cee34d5
Configure isomorphic tests with enzyme adapter
adidahiya 9efdfbf
Skip Portal isomorphic tests
adidahiya f2ec4e6
Load es6-shim in all tests
adidahiya d1c94a7
Fix NumericInput prop validation tests
adidahiya c7fa963
Add TestErrorBoundary component
adidahiya a1cc25a
Create @blueprintjs/test-commons package
adidahiya 391fadb
Fix DatePicker prop validation tests
adidahiya 4158d2e
Fix more prop validation tests
adidahiya 6d90e49
Fix more prop validation tests
adidahiya ecfa923
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya 307297b
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya 02cbae9
Fix up test config for latest Enzyme; load CSS files
adidahiya 3395389
Move tabs2 tests to their own folder
adidahiya ce4c03f
Skip more tests
adidahiya 53d894d
[CollapsibleList] fix unit tests
adidahiya 583507e
Add test:karma:debug NPM scripts to libraries
adidahiya 2f5a61b
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya c30628f
Upgrade tsc in test-commons package
adidahiya 9e94155
ReactWrapper#getNode() -> ReactWrapper#instance()
adidahiya b728ccb
Disable karma coverage in debug scripts
adidahiya b930727
Add two different abstract components, pure and not (#1896)
gscshoyru 18cb414
Remove unused overlayTransition.tsx
adidahiya 0b9ee4a
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya b4f5068
Fix semantic merge conflicts from select package moves
adidahiya e0238ad
Merge remote-tracking branch 'origin/ad/react-16' into ad/react-16
adidahiya 7f62bdd
Merge remote-tracking branch 'origin/master' into ad/react-16
adidahiya bf7bfb3
Fix core tests (#1898)
giladgray 9397fe8
Fix table tests (#1897)
themadcreator 3f38773
React 16/Enzyme 3 - Fix datetime tests (#1899)
cmslewis d4299b8
Skip abstractComponent coverage; fix select package test setup
adidahiya 6a49270
Address follow up comments on #1898
adidahiya 022586c
Remove extraneous core karma test config
adidahiya 5dbc249
Remove extra props interface in table impl
adidahiya aa47e76
Remove --browsers from test:karma:debug
adidahiya 71988dd
Address CR feedback on tests
adidahiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
*/ | ||
|
||
import * as classNames from "classnames"; | ||
import * as PureRender from "pure-render-decorator"; | ||
import * as React from "react"; | ||
|
||
import { Classes, IIntentProps, IProps } from "../../common"; | ||
|
@@ -31,8 +30,7 @@ export interface IIconProps extends IIntentProps, IProps { | |
iconSize?: 16 | 20 | "inherit"; | ||
} | ||
|
||
@PureRender | ||
export class Icon extends React.Component<IIconProps & React.HTMLAttributes<HTMLSpanElement>, never> { | ||
export class Icon extends React.PureComponent<IIconProps & React.HTMLAttributes<HTMLSpanElement>, never> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
public static displayName = "Blueprint.Icon"; | ||
|
||
public static readonly SIZE_STANDARD = 16 as 16; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to drop these empty
{}
state types, as the React types now provide a default:interface Component<P = {}, S = {}>
.though it's fine to not do this now, or ever.