Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak popover docs colors #2274

Merged
merged 3 commits into from
Mar 20, 2018
Merged

Tweak popover docs colors #2274

merged 3 commits into from
Mar 20, 2018

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Mar 19, 2018

  • better color for positioning buttons
  • same style for inset elements

@llorca llorca requested a review from giladgray March 19, 2018 21:38
@blueprint-bot
Copy link

Tweak popover docs colors

Preview: documentation | landing | table

@giladgray
Copy link
Contributor

scrollbars look awkward on new examples frames:
image

@llorca
Copy link
Contributor Author

llorca commented Mar 19, 2018

ack, ended up simplifying styles with no border/shadows, and solid background colors

@blueprint-bot
Copy link

simplify styles

Preview: documentation | landing | table

@giladgray giladgray merged commit b4de4e6 into develop Mar 20, 2018
@giladgray giladgray deleted the al/popover-docs branch March 20, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llorca @blueprint-bot @giladgray