Fix file input button shadow #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct variablePreview: documentation | landing | table |
|
I messed up the first commit, but funny thing: it works with |
remove extra line in variable declarationPreview: documentation | landing | table |
giladgray
reviewed
Mar 19, 2018
| inset 0 1px 2px rgba($black, 0.2) !default; | ||
| $dark-button-intent-box-shadow: 0 0 0 $button-border-width rgba($black, 0.4) !default; | ||
| $dark-button-intent-box-shadow-active: 0 0 0 $button-border-width rgba($black, 0.4), | ||
| inset 0 1px 2px rgba($black, 0.2) !default; |
There was a problem hiding this comment.
revert these whitespace changes please, the previous syntax was more legible.
add box shadow in a different selectorPreview: documentation | landing | table |
giladgray
approved these changes
Mar 19, 2018
| // it doesn't render correct via the `pt-button` mixin | ||
| // stylelint-disable-next-line | ||
| .pt-file-upload-input::after { box-shadow: $button-box-shadow; } | ||
| // stylelint-enable |
There was a problem hiding this comment.
don't need this since you're using -next-line (automatic re-enable)
llorca
changed the title
|
like shooting a target with eyes closed. can't believe this worked haha |
remove unnecessary stylelint enable linePreview: documentation | landing | table |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That shadow actually works fine locally without this change, but not on the docs website (the
::afterhas nobox-shadowrule). This PR explicitly adds abox-shadowrule to the::afterwithout relying on the mixin