-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subsections to Core > Components in nav #2546
Conversation
@@ -11,27 +13,49 @@ | |||
@page collapse | |||
@page collapsible-list | |||
@page context-menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is arguably an Overlay component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do it?
@page sliders | ||
@page checkbox | ||
@page switch | ||
@page radio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps one Toggles page for checkbox/switch/radio?
@page input-group | ||
@page file-input | ||
@page numeric-input | ||
@page tag-input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to group all the various inputs, but the Blah Input
naming looks messy in nav.
@## Forms | ||
|
||
@page form-group | ||
@page control-group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putting these first as they're crucial concepts to using the form components
|
||
<!-- now people will read the Overlay docs!! --> | ||
@page overlay | ||
@page portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two come first (intentionally breaking the alph) because they're basic concepts for this section.
@page alert | ||
@## Elements | ||
|
||
@page html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplest first
@@ -2,7 +2,9 @@ | |||
|
|||
<!-- Exact ordering of components in the navbar: --> | |||
|
|||
@page alert | |||
@## Elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other groups are cool, except this one. let's remove it
@page progress-bar | ||
@page skeleton | ||
@page spinner | ||
@page sliders | ||
@page table-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda feel like we should include this in HTML elements
then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i disagree, it does much more than those components. has its own modifiers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool
<!-- this guy's gonna go away shortly --> | ||
@page label | ||
|
||
@## Overlays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@page text | ||
@page tree | ||
|
||
@## Forms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, some details
|
remove Elements, bold heading always blackPreview: documentation | landing | table |
@giladgray small regression, package names look very thick now. can we bump back down to 600? everything else looks good. |
dang i hit the wrong selector, my bad |
move docs-nav-section to docs-app stylesPreview: documentation | landing | table |
split core components into three groups: Components | Forms | Overlays. some open questions remain about where some components belong. and i have no idea how to sanely organize the Forms section.
left some comments in the code with bits that need work.