-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] react-popper 1.0.0 #2609
Conversation
* The name of the HTML tag to use when rendering the popover target wrapper element (`Classes.POPOVER_WRAPPER`). | ||
* @default "span" | ||
*/ | ||
rootElementTag?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not let tooltips provide a wrapperTagName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have a follow up PR to introduce IPopoverSharedProps
that will resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i'll just open that now as there's a merge conflict here
opened #2617 which will reduce the diff here if merged first, so this PR is more focused on new react-popper API and not also changing props. |
add upgrade script entry for tooltipClassNamePreview: documentation | landing | table |
revert examples changePreview: documentation | landing | table |
Fixes #2530
Changes proposed in this pull request:
react-popper@1.0.0
which features a totally new API usingchildren
functions