New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox] add tagName prop #2708

Merged

giladgray merged 1 commit into develop from gg/checkbox

Jul 23, 2018

Contributor

giladgray commented Jul 21, 2018

add tagName prop so you can have a checkbox not wrapped in a <label>, which causes event problems when you listen for click on a parent element.
- obnoxious DOM side effect: pretty sure this is because clicking a label around an input also clicks the input and ends up triggering a whole bunch of events.
- set tagName="div" to render a beautiful checkbox that can be clicked directly (but not the text)


          add tagName prop to avoid label

b4baa92

giladgray requested review from invliD and themadcreator

July 21, 2018 00:28

invliD approved these changes

View reviewed changes

giladgray merged commit ae247ab into develop

giladgray deleted the gg/checkbox branch

July 23, 2018 16:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet