Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Rerender popovers when content resizes #2718

Merged
merged 11 commits into from
Jul 24, 2018
Merged

[Core] Rerender popovers when content resizes #2718

merged 11 commits into from
Jul 24, 2018

Commits on Jul 24, 2018

  1. Add ResizeObserver to force popper to rerender when content resizes

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    2b4c3c8 View commit details
    Browse the repository at this point in the history

  2. Rework observer/resize implmentation, as was only working on intial r… 

    …ender
    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    15ae92c View commit details
    Browse the repository at this point in the history

  3. fix typo in comment

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    6394932 View commit details
    Browse the repository at this point in the history

  4. Fixing popperUpdater type definition

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    94078b7 View commit details
    Browse the repository at this point in the history

  5. Align with code style guides

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    3788f2a View commit details
    Browse the repository at this point in the history

  6. Clean up implementation as per review

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    ca0de37 View commit details
    Browse the repository at this point in the history

  7. Fixing lint error

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    fdfd8a3 View commit details
    Browse the repository at this point in the history

  8. Only initialise observer once, disconnect to clear observations

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    6510801 View commit details
    Browse the repository at this point in the history

  9. Reword comment

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    a9838d8 View commit details
    Browse the repository at this point in the history

  10. Use safeInvoke to avoid type coercion

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    53d42af View commit details
    Browse the repository at this point in the history

  11. follow convention when checking if ref exists

    Byron Adams committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    294e219 View commit details
    Browse the repository at this point in the history