Fixed issues in toastr timeouts #3244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
suggested changes
Jan 9, 2019
| this.startTimeout(); | ||
| } else if (prevProps.timeout <= 0 && this.props.timeout > 0) { | ||
| this.startTimeout(); | ||
| } else if (prevProps.timeout > 0 && this.props.timeout <= 0) { | ||
| this.clearTimeouts(); | ||
| this.triggerDismiss(false); |
There was a problem hiding this comment.
this is not the desired behavior -- setting timeout to 200 and then to 0 should never dismiss that toast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
I recently pushed a change to fix an issue with toasts where new timeout props were getting ignored. Now I just found a similar issue where the old timeout would still trigger and clear the toast anyways.
Separately why is the third condition to clearTimeouts. That would make the toastr stay forever. Shouldn't it just trigger the dismiss immediately?