Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add separate colors sketch library with name colors in palette and shared styles #3932

Closed
wants to merge 2 commits into from

Conversation

estevesd
Copy link
Contributor

Add new Sketch Library

Changes proposed in this pull request:

Add new Sketch Library for colors.
Colors are named according to the variables defined in @blueprint/core.
Colors are available in the palette as well as in shared styles

Reviewers should focus on:

Is it useful for everyone? or only me?

Screenshot

blueprint-colors
bluebrint_sketchpalette

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @estevesd! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@estevesd
Copy link
Contributor Author

perhaps this should be added to the kit instead of a separate library ?

@aycai
Copy link
Contributor

aycai commented Jan 24, 2020

Yep, adding it to the kit makes sense - components and icons will benefit from this!

Sketch currently treats text and layer styles as separate lists, I think removing the text colors and adding them into their respective text styles makes more sense.

@aycai
Copy link
Contributor

aycai commented Jan 24, 2020

Checked the file in #2817, looks good there 👍

@aycai aycai self-requested a review January 24, 2020 00:11
@aycai
Copy link
Contributor

aycai commented Apr 14, 2020

hey @estevesd, wanted to close the loop here. We're planning on merging in #4007 which I believe contains these changes, so going to close this PR. Does that sound good?

@estevesd
Copy link
Contributor Author

Hi @aycai. Sounds very good. Awesome work from @terpimost on #4007

@adidahiya adidahiya closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants