Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(TagInput): handle delete to remove items #3993

Merged

Commits on Feb 29, 2020

  1. Handle DELETE to remove items in <TagInput />

    Allows users to press `DELETE` on their keyboards to delete
    an item from `<TagInput />`, which in turn is used by the
    `Select` family of components.
    
    Handling `DELETE` to remove item mimics the way `DELETE` works
    in a text editor, where an user can delete from the beginning
    of the line forward. Reaching the end of the line, in our
    case passing the last selected item in `<TagInput />` will stop
    deleting. Moving the selection to the first item and deleting
    from that point onwards repeatedly will delete all the selected
    items.
    grancalavera committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    6200960 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7c0645 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Use full stop before describing delete behavior.

    Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>
    grancalavera and adidahiya authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    11c30b5 View commit details
    Browse the repository at this point in the history