Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime] feat: support highlightCurrentDay prop in more components #4314

Merged

Conversation

ejose19
Copy link
Contributor

@ejose19 ejose19 commented Sep 6, 2020

Add missing highlightCurrentDay prop for dateInput (which already supported it), and port support to dateRangePicker/dateRangeInput

@ejose19
Copy link
Contributor Author

ejose19 commented Sep 7, 2020

@J-Vin Care to explain what do you mean exactly?

packages/datetime/src/dateRangePicker.tsx Outdated Show resolved Hide resolved
packages/datetime/src/dateRangePicker.tsx Outdated Show resolved Hide resolved
packages/datetime/src/dateInput.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title refactor: expose highlightCurrentDay prop and add it to dateRangePicker [datetime] feat: support highlightCurrentDay prop in more components Sep 8, 2020
@ejose19
Copy link
Contributor Author

ejose19 commented Sep 8, 2020

@adidahiya I've applied your reviews and also moved dayPickerProps to IDatePickerBaseProps since that one is also being used in all day picker components.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @ejose19

@adidahiya adidahiya merged commit d9925e1 into palantir:develop Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants