-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[select] feat: createNewItemPosition prop #4401
[select] feat: createNewItemPosition prop #4401
Conversation
hmm, this build fail does not happen locally. are you familiar with this one? |
@giladgray had the same issue locally on node 14 - switching back to node 12 seems to fix the problem. |
i'm on node 12 locally, maybe that's why it works on my box? doesn't make sense how i can only edit @adidahiya do you have insight here? |
@giladgray looks like Node 14 got promoted to the "lts" docker image. This should fix the build: #4405 |
🙌 great catch! thanks @adidahiya for the quick perfect fix 🚀 |
@adidahiya i don't mean to be a bother, but do you have a timeline for reviewing / releasing this? jonesing to use this prop ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! should have this in a release early next week
Checklist
Changes proposed in this pull request:
createNewItemPosition?: "first" | "last"
prop on QueryList (defaults to "last" - current behavior)Reviewers should focus on:
👋 hey buddy, hope you're well! this was fun to put together, and to revisit the project. i may have another
select
PR or two coming your way soon...Screenshot