chore: enable more ESLint rules

[adidahiya]

PR summary

• Disabled these TSLint rules
  • file-header
  • ordered-imports
  • all tslint-react-rules
    • jsx-boolean-value
    • jsx-key
    • jsx-no-bind
    • jsx-no-lambda
    • jsx-no-string-ref
    • jsx-self-close
• Enabled these ESLint rules
  • header/header
  • jsdoc/newline-after-description
  • import/order
    • note: the config group named "internal" was a little confusing to me at first look, eventually I realized this could help specify where to put @blueprintjs/ package imports
  • @typescript-eslint/lines-between-class-members
  • @typescript-eslint/no-unncessary-type-constraint
  • eslint-plugin-react rules
    • all counterparts from tslint-react
    • plus some more new ones
• Chose not to enable these rules
  • cannot enable consistent-type-imports because of [consistent-type-imports] add option to autofix to a single type import typescript-eslint/typescript-eslint#2769
  • no-implicit-any-catch is useless because the only allowable types are any | unknown. doesn’t make much sense to distinguish between these two IMO

Most of the diff is adding newlines.

Remaining migration work

these rules do not have suitable replacements yet:

• only-arrow-functions
  • prefer-arrow/prefer-arrow-functions is missing "allow named functions" option, see allow-named-functions option TristonJ/eslint-plugin-prefer-arrow#17
• no-submodule-imports
  • import/no-internal-modules does not have an option to only apply to node_modules, and it doesn't seem like they are likely to add it, so we should write this rule ourselves, see Only apply no-internal-modules to node_modules import-js/eslint-plugin-import#1430
• object-literal-sort-keys
  • sort-keys does not have an option to ignore single line object literals, GH issue forthcoming...

these rules need to be migrated to use equivalent eslint config:

• variable-name

[blueprint-bot]

enable no-unnecessary-type-constraint

Previews: documentation | landing | table

[blueprint-bot]

Enable react plugin lint rules

Previews: documentation | landing | table

[blueprint-bot]

Disable some new lint rules in docs-app

Previews: documentation | landing | table

[blueprint-bot]

Merge remote-tracking branch 'origin/develop' into ad/eslint-rules

Previews: documentation | landing | table

[blueprint-bot]

autofix all import ordering with new config

Previews: documentation | landing | table