Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial AccessibleButton component #4839

Closed

Conversation

evansjohnson
Copy link
Contributor

@evansjohnson evansjohnson commented Aug 5, 2021

Checklist

  • Includes tests
  • Update documentation

Will add tests if this gets general go ahead nod.

Changes proposed in this pull request:

Add an AccessibleButton utility component to abstract away making a non <button> component properly clickable

Would come in handy for #3079, #4810 (tabIndex={0} won't really help if can't be triggered by keyboard while focused), #4782, and other tickets requiring keyboard support

Reviewers should focus on:

Is this a component Blueprint wants to support?

Is it implemented correctly?

  • Also considered if it should be a <button> component that removes all styling, though perhaps less flexible for consumers

AccessibleButtonProps doesn't extend anything right now, had trouble finding something that worked everything seemed to cause some issue. Will fix up if this gets a general go ahead nod.

Screencap

AccessibleButtonDemo

@adidahiya
Copy link
Contributor

we added this to an internal component library; will reconsider adding it to Blueprint after it's had some time to bake there

@adidahiya adidahiya closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants