[table] fix(Table2): uncontrolled resizing of cols/rows #5202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes resizing rows/cols not visually updating for Tables that don't use the
columnWidths
/rowHeights
prop.I think this was introduced here where before we were comparing
props.columnWidths
toprevState.columnWidths
whereprops.columnWidths
was alwaysundefined
for Tables not using the prop. Now that there is an undefined checkdidColumnWidthsChange
will always be false for Tables not using the prop.Maybe a better spot for this update is in
handleColumnWidthChanged
? We callvalidateGrid
there, but that doesn't seem to visually update the table with the new sizes.Checklist
Changes proposed in this pull request:
Added a check that prevState !== currentState for column widths and row heights when the prop is not set
Screenshot
before:

after:
