Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime] fix(a11y): add aria-labels for various controls #5358

Merged
merged 2 commits into from
Jun 7, 2022
Merged

[datetime] fix(a11y): add aria-labels for various controls #5358

merged 2 commits into from
Jun 7, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

fix datepicker a11y issues

adidahiya
adidahiya suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

packages/datetime/src/datePickerCaption.tsx Outdated Show resolved Hide resolved
packages/datetime/src/datePickerCaption.tsx Outdated Show resolved Hide resolved
packages/datetime/src/datePickerNavbar.tsx Outdated Show resolved Hide resolved
packages/datetime/src/datePickerNavbar.tsx Outdated Show resolved Hide resolved
packages/datetime/src/shortcuts.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title a11y datepicker fixes [datetime] fix: add aria-labels for various controls Jun 7, 2022
@adidahiya adidahiya changed the title [datetime] fix: add aria-labels for various controls [datetime] fix(a11y): add aria-labels for various controls Jun 7, 2022
@adidahiya adidahiya merged commit d9d20dc into palantir:develop Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitrisx dimitrisx dimitrisx left review comments

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvandercar-vt @adidahiya @dimitrisx