Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] fix(DateInput2): clearing input calls onChange(null) #5409

Merged
merged 7 commits into from
Jul 7, 2022

Conversation

vhellem
Copy link
Contributor

@vhellem vhellem commented Jul 1, 2022

Fixes #5408

Checklist

Changes proposed in this pull request:

DateInput2 will now also propagate changes that set's the date as null.

Reviewers should focus on:

with_revert

@vhellem vhellem requested a review from adidahiya July 7, 2022 07:08
packages/datetime2/package.json Outdated Show resolved Hide resolved
@blueprint-bot
Copy link

Update packages/datetime2/package.json

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

code style fixes

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

add unit test

Previews: documentation | landing | table | demo

@adidahiya adidahiya changed the title Fix ability to clear values in dateInput2 [datetime2] fix(DateInput2): clearing input calls onChange(null) Jul 7, 2022
@adidahiya adidahiya merged commit 420abcf into develop Jul 7, 2022
@adidahiya adidahiya deleted the vhellem/ability_to_clear_datepicker2_value branch July 7, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateInput2] Clearing value does not propagate to consumer
3 participants