-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MenuItem2 component #5471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenuItem2 component, part 4: migrate to MenuItem2 within repoPreviews: documentation | landing | table | demo |
fix unit testsPreviews: documentation | landing | table | demo |
adidahiya
commented
Jul 27, 2022
|
||
import { Clipboard } from "../../common/clipboard"; | ||
import { TABLE_COPY_FAILED } from "../../common/errors"; | ||
import { Regions } from "../../regions"; | ||
import { IMenuContext } from "./menuContext"; | ||
|
||
export interface ICopyCellsMenuItemProps extends MenuItemProps { | ||
export interface ICopyCellsMenuItemProps extends MenuItem2Props { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is a small breaking change, but in practice I think it should be ok for consumers since I didn't see any usage of popoverProps: Partial<IPopoverProps>
for this component in any of our code bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
children
defined (those which have submenus), but we cannot do that with TypeScript's JSX type checking features, so we must deprecate MenuItem completely to be safe.Reviewers should focus on:
No regressions in MenuItem2 docs example compared to MenuItem
Screenshot
MenuItem2 example:
Updated Popover2 example:
Updated Select2 example:
Updated icon docs page:
Updated ContextMenu2 example:
Updated table example: