Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] feat(DateRangeInput2): remove target wrapper element #5474

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 1, 2022

Changes proposed in this pull request:

Similar to #5473, this PR refactors DateRangeInput2 to use Popover2's renderTarget API, which allows us to flatten the rendered DOM by one level and combine the ControlGroup element w/ the Popover2 target element. Also added .bp4-date-range-input and .bp4-date-range-input-popover classes (surprised they weren't there before in <DateRangeInput>):

- <span aria-haspopup="true" class="bp4-popover2-target">
-     <div class="bp4-control-group">
-         <div class="bp4-input-group">...</div>
-         <div class="bp4-input-group">...</div>
-     </div>
- </span>
+ <div aria-haspopup="true" class="bp4-control-group bp4-date-range-input bp4-popover2-target">
+     <div class="bp4-input-group">...</div>
+     <div class="bp4-input-group">...</div>
+ </div>

Reviewers should focus on:

No regressions in behavior (should be covered by test suite)

Screenshot

@blueprint-bot
Copy link

[datetime2] feat(DateRangeInput2): remove target wrapper element

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Add classes

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 92256ff into develop Aug 1, 2022
@adidahiya adidahiya deleted the ad/date-range-input2-renderTarget branch August 1, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants