[datetime2] feat(DateRangeInput2): remove target wrapper element #5474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Similar to #5473, this PR refactors DateRangeInput2 to use Popover2's
renderTarget
API, which allows us to flatten the rendered DOM by one level and combine the ControlGroup element w/ the Popover2 target element. Also added.bp4-date-range-input
and.bp4-date-range-input-popover
classes (surprised they weren't there before in<DateRangeInput>
):Reviewers should focus on:
No regressions in behavior (should be covered by test suite)
Screenshot