[core] feat(Portal): add support for new context API #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] feat(Portal): add support for new context APIPreviews: documentation | landing | table | demo |
combine into one component, fix testsPreviews: documentation | landing | table | demo |
adidahiya
added a commit
that referenced
this pull request
Aug 24, 2022
adidahiya
added a commit
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually fix #5139, but for now we need to keep legacy context for backwards-compatibility, so the console warning will remain.
Checklist
Changes proposed in this pull request:
React.createPortalnot being available)PortalContextandPortalProviderAPIs which allow setting global options on Portals in a given React subtree using the newer React context APIPortalContextfor forwards-compatibility with the newPortalProviderAPI, while retaining backwards-compatibility with the legacy context API (legacyContext: PortalLegacyContextpassed in the constructor)Reviewers should focus on:
No regressions