Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Tabs, Switch): improve high contrast mode support #5668

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

styu
Copy link
Contributor

@styu styu commented Oct 12, 2022

Partially addresses #5622

Changes proposed in this pull request:

Adds high contrast mode support for Blueprint tabs
I also ended up fixing the high contrast mode for switches in dark theme, since I noticed that as I was testing out the dark theme + high contrast combo for the tabs

Reviewers should focus on:

Do active/disabled/normal states look ok?

@blueprint-bot
Copy link

Add high contrast mode support for Blueprint tabs

Previews: documentation | landing | table | demo

@adidahiya
Copy link
Contributor

Looks good in light theme.

Minor feedback: vertical tabs could probably use a highlighted background, but this is low priority since we don't see vertical tabs used often.

2022-10-12 16 42 51

Dark theme indicators are still not getting the highlight color:

image

@styu
Copy link
Contributor Author

styu commented Oct 14, 2022

The vertical tab background is kind of rough to deal with because we have !important here:

.#{$ns}-tab-indicator-wrapper ~ & {
// these properties are only for static markup, therefore
// we never want them if there's a tab indicator
/* stylelint-disable declaration-no-important */
background-color: transparent !important;
box-shadow: none !important;
/* stylelint-enable declaration-no-important */
}

@blueprint-bot
Copy link

fix switch outline, try and fix vertical/dark mode tabs

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Fix more dark mode styles

Previews: documentation | landing | table | demo

@styu styu marked this pull request as ready for review October 14, 2022 10:55
@styu styu changed the title Add high contrast mode support for Blueprint tabs Add high contrast mode support for Blueprint tabs, fix dark theme switch control styles Oct 14, 2022
@blueprint-bot
Copy link

disable

Previews: documentation | landing | table | demo

@adidahiya adidahiya changed the title Add high contrast mode support for Blueprint tabs, fix dark theme switch control styles [core] fix(Tabs, Switch): improve high contrast mode support Oct 14, 2022
@adidahiya adidahiya merged commit c49738a into develop Oct 14, 2022
@adidahiya adidahiya deleted the syu/high-contrast-tabs branch October 14, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants