-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix(Tabs, Switch): improve high contrast mode support #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add high contrast mode support for Blueprint tabsPreviews: documentation | landing | table | demo |
The vertical tab background is kind of rough to deal with because we have blueprint/packages/core/src/components/tabs/_tabs.scss Lines 108 to 115 in 980c634
|
fix switch outline, try and fix vertical/dark mode tabsPreviews: documentation | landing | table | demo |
Fix more dark mode stylesPreviews: documentation | landing | table | demo |
styu
changed the title
Add high contrast mode support for Blueprint tabs
Add high contrast mode support for Blueprint tabs, fix dark theme switch control styles
Oct 14, 2022
disablePreviews: documentation | landing | table | demo |
adidahiya
approved these changes
Oct 14, 2022
adidahiya
changed the title
Add high contrast mode support for Blueprint tabs, fix dark theme switch control styles
[core] fix(Tabs, Switch): improve high contrast mode support
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5622
Changes proposed in this pull request:
Adds high contrast mode support for Blueprint tabs
I also ended up fixing the high contrast mode for switches in dark theme, since I noticed that as I was testing out the dark theme + high contrast combo for the tabs
Reviewers should focus on:
Do active/disabled/normal states look ok?