Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icon "at" #5670

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

wangyuy22
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds new icon for @ symbol.

Reviewers should focus on:

Screenshot

image

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @wangyuy22! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, just some minor feedback on icon metadata

image

packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title Add new "at" icon [icons] feat: new icon "at" Oct 17, 2022
@adidahiya adidahiya merged commit 73514d6 into palantir:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants